Thread (9 messages) 9 messages, 2 authors, 2011-08-31

Re: [PATCH 2/2] xfs: fix ->write_inode return values

From: Dave Chinner <david@fromorbit.com>
Date: 2011-08-30 06:25:36

On Sat, Aug 27, 2011 at 01:57:55AM -0400, Christoph Hellwig wrote:
Currently we always redirty an inode that was attempted to be written out
synchronously but has been cleaned by an AIL pushed internall, which is
rather bogus.  Fix that by doing the i_update_core check early on and
return 0 for it.  Also include async calls for it, as doing any work for
those is just as pointless.  While we're at it also fix the sign for the
EIO return in case of a filesystem shutdown, and fix the completely
non-sensical locking around xfs_log_inode.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Makes sense.

Reviewed-by: Dave Chinner <redacted>

-- 
Dave Chinner
david@fromorbit.com

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help