Thread (4 messages) 4 messages, 2 authors, 2011-06-28

Re: [PATCH] xfs_repair: Check if agno is inside the filesystem

From: Dave Chinner <david@fromorbit.com>
Date: 2011-06-28 01:28:42

On Mon, Jun 27, 2011 at 06:53:30PM +0200, Lukas Czerner wrote:
When getting an inode tree pointer from an array inode_tree_ptrs, we
should check if agno, which is used as a pointer to the array, lives
within the file system, because if it is not, we can end up touching
uninitialized memory.
How do you get an agno outside the bounds of the filesystem?
This commit fixes it by passing xfs_mount_t to affected functions and
checking if agno really is inside the file system.
We're slowly removing typedefs as we change code. So probably better
to use struct xfs_mount for all the places where you add an
xfs_mount_t.

Otherwise seems fine.

Cheers,

Dave.
-- 
Dave Chinner
david@fromorbit.com

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help