On Mon, Jan 24, 2011 at 03:47:32AM -0500, Christoph Hellwig wrote:

quoted

+typedef	int32_t	atomic_t;
+typedef	int64_t	atomic64_t;
+
+#define atomic_inc_return(x)	(++(*(x)))
+#define atomic_dec_return(x)	(--(*(x)))
+
+#define atomic64_read(x)	*(x)
+#define atomic64_set(x, v)	(*(x) = v)

These defintions are pretty dangerous if we ever happens to use
them in multi-threaded code like repair.   Currently we're not,
but they should grow a larger warning comment.

Ok, I'll add a warning to that effect.

quoted

--- /dev/null
+++ b/include/hlist.h

Why not add the hlist helpers to list.h, like in the kernel tree?

It was just a side effect of the process I followed to add the bits
of missing functionality that were needed. I can add it to list.h if
you want, but I don't think it really matters either way...

Cheers,

Dave.
-- 
Dave Chinner
david@fromorbit.com

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs