From: Pagadala Yesu Anjaneyulu <redacted>
The version guard used `< 1` instead of `!= 1`. With `< 1` the
command would be sent for any firmware version >= 1, including
future versions that may have a different structure, which could
trigger a firmware assert due to a size/format mismatch.
Fix the check to `!= 1` so the command is only sent when the
firmware supports exactly version 1.
Fixes: ebc246e1d5a3 ("wifi: iwlwifi: mvm: add LARI_CONFIG_EXTENSION command")
Signed-off-by: Pagadala Yesu Anjaneyulu <redacted>
Signed-off-by: Miri Korenblit <miriam.rachel.korenblit@intel.com>
---
drivers/net/wireless/intel/iwlwifi/mvm/fw.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/intel/iwlwifi/mvm/fw.c b/drivers/net/wireless/intel/iwlwifi/mvm/fw.c
index 43a7230f1ab4..06f3b065914b 100644
--- a/drivers/net/wireless/intel/iwlwifi/mvm/fw.c
+++ b/drivers/net/wireless/intel/iwlwifi/mvm/fw.c
@@ -1526,7 +1526,7 @@ static void iwl_mvm_send_lari_cfg_extension(struct iwl_mvm *mvm)
u32 value;
int ret;
- if (iwl_fw_lookup_cmd_ver(mvm->fw, cmd_id, 0) < 1)
+ if (iwl_fw_lookup_cmd_ver(mvm->fw, cmd_id, 0) != 1)
return;
ret = iwl_bios_get_dsm(fwrt, DSM_FUNC_REGULATORY_CONFIG, &value);
--
2.34.1