Thread (10 messages) 10 messages, 3 authors, 17d ago

RE: [PATCH rtw-next v3 3/3] wifi: rtl8xxxu: preserve RX requests across recoverable transfer errors

flat view

From: Ping-Ke Shih <pkshih@realtek.com>
Date: 2026-09-21 00:24:56
Also in: lkml

Kim Wooseok [off-list ref] wrote:
quoted
Not prefer using bare system_wq.
Can both use schedule_delayed_work()?
In v3, the error path uses queue_delayed_work(system_wq, ..., delay),
while normal completions use mod_delayed_work(system_wq, ..., 0).

I can replace the error-path call with schedule_delayed_work().
However, the normal-completion path is intended to bring an existing
delayed retry forward when the pending count exceeds the batching
threshold, which schedule_delayed_work(..., 0) cannot do because it
leaves an already pending timer unchanged.
I knew this point. Does it matter to schedule a normal case immediately
after an error case (defer to schedule) happened within 100ms?
(Just an open question)
Would it be OK to retain mod_delayed_work() for normal completions,
changing its queue argument to system_percpu_wq?
OK if above question is yes. 

Or both change to use mod_delayed_work()?
With that change, schedule_delayed_work() would select system_percpu_wq
internally, and mod_delayed_work() would use the same queue explicitly.
  
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help