Thread (12 messages) 12 messages, 4 authors, 2024-08-29

Re: [PATCH v13 3/5] dt-bindings: net: wireless: brcm4329-fmac: change properties enum structure

From: Jacobe Zang <hidden>
Date: 2024-08-28 13:20:40
Also in: linux-devicetree, lkml, netdev


On 2024/8/28 21:04, Krzysztof Kozlowski wrote:
On 28/08/2024 10:49, Jacobe Zang wrote:
quoted
Add "brcm,bcm4329-fmac" as fallback compatible for wireless devices that
used PCI ID based compatible. So that can pass the compatible check in
driver.
Driver? Why this has to pass compatible check?

I think I asked to provide proper rationale based on hardware... if not,
then let me ask here: Please provide proper rationale explaining how
this hardware is compatible, especially considering these are entirely
different buses (SDIO and PCI!).

It feels you patch up bindings and DTS, because of buggy driver. Sorry
no, fix the driver.
All right. Anyway after discussion in the other series, this patch 
should be dropped, and driver also need to fix.

-- 
Best Regards
Jacobe
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help