[PATCH v1] wifi: mac80211: use kmemdup_array instead of kmemdup for multiple allocation
flat view
STALE777d
From: Shen Lichuan <hidden>
Date: 2024-08-27 03:57:20
Also in:
lkml, netdev
Subsystem:
mac80211, the rest · Maintainers:
Johannes Berg, Linus Torvalds
Let the kmemdup_array() take care about multiplication and possible overflows. Using kmemdup_array() is more appropriate and makes the code easier to audit. Signed-off-by: Shen Lichuan <redacted> --- net/mac80211/main.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/net/mac80211/main.c b/net/mac80211/main.c
index a3104b6ea6f0..f16ebad36a83 100644
--- a/net/mac80211/main.c
+++ b/net/mac80211/main.c@@ -1051,9 +1051,9 @@ static int ieee80211_init_cipher_suites(struct ieee80211_local *local) return 0; /* Driver provides cipher suites, but we need to exclude WEP */ - suites = kmemdup(local->hw.wiphy->cipher_suites, - sizeof(u32) * local->hw.wiphy->n_cipher_suites, - GFP_KERNEL); + suites = kmemdup_array(local->hw.wiphy->cipher_suites, + local->hw.wiphy->n_cipher_suites, sizeof(u32), + GFP_KERNEL); if (!suites) return -ENOMEM;
--
2.17.1