Thread (1 message) 1 message, 1 author, 2023-06-14

[PATCH] wifi: rtw89: Remove unneeded variable

DORMANTno replies

From: <hidden>
Date: 2023-06-14 06:28:39
Also in: lkml
Subsystem: realtek wireless driver (rtw89), the rest · Maintainers: Ping-Ke Shih, Linus Torvalds

Possibly related (same subject, not in this thread)

Fix the following coccicheck warning:

drivers/net/wireless/realtek/rtw89/pci.c:239:5-8: Unneeded variable: "cnt".

Signed-off-by: Zhenggang Xuan <redacted>
---
 drivers/net/wireless/realtek/rtw89/pci.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/net/wireless/realtek/rtw89/pci.c b/drivers/net/wireless/realtek/rtw89/pci.c
index 9402f1a0caea..591b7b9a6eca 100644
--- a/drivers/net/wireless/realtek/rtw89/pci.c
+++ b/drivers/net/wireless/realtek/rtw89/pci.c
@@ -236,7 +236,6 @@ static u32 rtw89_pci_rxbd_deliver_skbs(struct rtw89_dev *rtwdev,
     struct sk_buff *skb;
     u32 rxinfo_size = sizeof(struct rtw89_pci_rxbd_info);
     u32 offset;
-    u32 cnt = 1;
     bool fs, ls;
     int ret;
@@ -297,7 +296,7 @@ static u32 rtw89_pci_rxbd_deliver_skbs(struct rtw89_dev *rtwdev,
         desc_info->ready = false;
     }

-    return cnt;
+    return 1;

 err_sync_device:
     rtw89_pci_sync_skb_for_device(rtwdev, skb);
@@ -308,7 +307,7 @@ static u32 rtw89_pci_rxbd_deliver_skbs(struct rtw89_dev *rtwdev,
     rx_ring->diliver_skb = NULL;
     desc_info->ready = false;

-    return cnt;
+    return 1;
 }

 static void rtw89_pci_rxbd_deliver(struct rtw89_dev *rtwdev,
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help