Re: [PATCH v1 01/17] thermal/core: Add a thermal zone 'devdata' accessor
flat view
From: Sebastian Reichel <hidden>
Date: 2023-02-20 13:24:05
Also in:
linux-acpi, linux-arm-msm, linux-hwmon, linux-ide, linux-iio, linux-input, linux-mediatek, linux-omap, linux-pm, linux-renesas-soc, linux-samsung-soc, linux-sunxi, linux-tegra, lkml, netdev
Hi, On Sun, Feb 19, 2023 at 03:36:41PM +0100, Daniel Lezcano wrote:
The thermal zone device structure is exposed to the different drivers and obviously they access the internals while that should be restricted to the core thermal code. In order to self-encapsulate the thermal core code, we need to prevent the drivers accessing directly the thermal zone structure and provide accessor functions to deal with. Provide an accessor to the 'devdata' structure and make use of it in the different drivers. No functional changes intended. Signed-off-by: Daniel Lezcano <redacted> ---
...
drivers/power/supply/power_supply_core.c | 2 +-
...
quoted hunk ↗ jump to hunk
diff --git a/drivers/power/supply/power_supply_core.c b/drivers/power/supply/power_supply_core.c index 7c790c41e2fe..166f0aacc797 100644 --- a/drivers/power/supply/power_supply_core.c +++ b/drivers/power/supply/power_supply_core.c@@ -1142,7 +1142,7 @@ static int power_supply_read_temp(struct thermal_zone_device *tzd, int ret; WARN_ON(tzd == NULL); - psy = tzd->devdata; + psy = thermal_zone_device_get_data(tzd); ret = power_supply_get_property(psy, POWER_SUPPLY_PROP_TEMP, &val); if (ret) return ret;
Acked-by: Sebastian Reichel <redacted> -- Sebastian
Attachments
- signature.asc [application/pgp-signature] 833 bytes