Re: [PATCH v2 4/4] nios2: dts: Fix tse_mac "max-frame-size" property

From
Dinh Nguyen <dinguyen@kernel.org>
Date
2023-02-16 15:54:12
Also in
linux-devicetree, lkml, netdev
Reply to
Janne Grunau, 2023-02-12

On 2/12/23 06:16, Janne Grunau wrote:
quoted hunk ↗ jump to hunk
The given value of 1518 seems to refer to the layer 2 ethernet frame
size without 802.1Q tag. Actual use of the "max-frame-size" including in
the consumer of the "altr,tse-1.0" compatible is the MTU.

Fixes: 95acd4c7b69c ("nios2: Device tree support")
Fixes: 61c610ec61bb ("nios2: Add Max10 device tree")
Signed-off-by: Janne Grunau <j@jannau.net>
---
  arch/nios2/boot/dts/10m50_devboard.dts | 2 +-
  arch/nios2/boot/dts/3c120_devboard.dts | 2 +-
  2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/nios2/boot/dts/10m50_devboard.dts b/arch/nios2/boot/dts/10m50_devboard.dts
index 56339bef3247..0e7e5b0dd685 100644
--- a/arch/nios2/boot/dts/10m50_devboard.dts
+++ b/arch/nios2/boot/dts/10m50_devboard.dts
@@ -97,7 +97,7 @@ rgmii_0_eth_tse_0: ethernet@400 {
  			rx-fifo-depth = <8192>;
  			tx-fifo-depth = <8192>;
  			address-bits = <48>;
-			max-frame-size = <1518>;
+			max-frame-size = <1500>;
  			local-mac-address = [00 00 00 00 00 00];
  			altr,has-supplementary-unicast;
  			altr,enable-sup-addr = <1>;
diff --git a/arch/nios2/boot/dts/3c120_devboard.dts b/arch/nios2/boot/dts/3c120_devboard.dts
index d10fb81686c7..3ee316906379 100644
--- a/arch/nios2/boot/dts/3c120_devboard.dts
+++ b/arch/nios2/boot/dts/3c120_devboard.dts
@@ -106,7 +106,7 @@ tse_mac: ethernet@4000 {
  				interrupt-names = "rx_irq", "tx_irq";
  				rx-fifo-depth = <8192>;
  				tx-fifo-depth = <8192>;
-				max-frame-size = <1518>;
+				max-frame-size = <1500>;
  				local-mac-address = [ 00 00 00 00 00 00 ];
  				phy-mode = "rgmii-id";
  				phy-handle = <&phy0>;
Applied!

Thanks,
Dinh
Thread (11 messages) 11 messages, 5 authors, last reply 2023-02-20
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help