Re: [PATCH 5.10 1/1] mt76: fix mt7615_init_tx_queues() return value

On Mon, Jan 30, 2023 at 01:48:24PM +0000, Жандарович Никита Игоревич wrote:

quoted

On Mon, Jan 30, 2023 at 01:27:26PM +0000, Жандарович Никита Игоревич
wrote:

quoted

quoted

What is the git commit id of this upstream?

And I can't apply this as-is for the obvious reason it would mess up
the changelog, how did you create this?

confused,

greg k-h

Commit in question is b671da33d1c5973f90f098ff66a91953691df582
upstream. I wasn't certain it makes sense to backport the whole patch
as only a small portion of it pertains to the fault at question.

What is the "fault"?

In 5.10.y "mt7615_init_tx_queues() returns 0 regardless of how final
mt7615_init_tx_queue() performs. If mt7615_init_tx_queue() fails (due to
memory issues, for instance), parent function will still erroneously
return 0."

And how can memory issues actually be triggered in a real system?  Is
this a fake problem or something you can validate and verify works
properly?

Don't worry about fake issues for stable backports please.

thanks,

greg k-h