Re: [PATCH net-next 01/12] dt-bindings: net: bcm4329-fmac: Add Apple properties & chips
From: Rob Herring <robh@kernel.org>
Date: 2022-09-07 15:48:10
Also in:
asahi, linux-arm-kernel, linux-devicetree, netdev
On Wed, Sep 07, 2022 at 08:47:46AM +0100, Russell King wrote:
quoted hunk ↗ jump to hunk
From: Hector Martin <redacted> This binding is currently used for SDIO devices, but these chips are also used as PCIe devices on DT platforms and may be represented in the DT. Re-use the existing binding and add chip compatibles used by Apple T2 and M1 platforms (the T2 ones are not known to be used in DT platforms, but we might as well document them). Then, add properties required for firmware selection and calibration on M1 machines. Reviewed-by: Linus Walleij <redacted> Signed-off-by: Hector Martin <redacted> Signed-off-by: Russell King (Oracle) <redacted> --- .../net/wireless/brcm,bcm4329-fmac.yaml | 37 +++++++++++++++++-- 1 file changed, 34 insertions(+), 3 deletions(-)diff --git a/Documentation/devicetree/bindings/net/wireless/brcm,bcm4329-fmac.yaml b/Documentation/devicetree/bindings/net/wireless/brcm,bcm4329-fmac.yaml index 53b4153d9bfc..53ded82b273a 100644 --- a/Documentation/devicetree/bindings/net/wireless/brcm,bcm4329-fmac.yaml +++ b/Documentation/devicetree/bindings/net/wireless/brcm,bcm4329-fmac.yaml@@ -4,7 +4,7 @@ $id: http://devicetree.org/schemas/net/wireless/brcm,bcm4329-fmac.yaml# $schema: http://devicetree.org/meta-schemas/core.yaml# -title: Broadcom BCM4329 family fullmac wireless SDIO devices +title: Broadcom BCM4329 family fullmac wireless SDIO/PCIE devices maintainers: - Arend van Spriel <arend@broadcom.com>@@ -42,10 +42,16 @@ title: Broadcom BCM4329 family fullmac wireless SDIO devices - cypress,cyw43012-fmac - const: brcm,bcm4329-fmac - const: brcm,bcm4329-fmac
If you respin, this compatible can be combined with the enum below.
+ - enum: + - pci14e4,43dc # BCM4355 + - pci14e4,4464 # BCM4364 + - pci14e4,4488 # BCM4377 + - pci14e4,4425 # BCM4378 + - pci14e4,4433 # BCM4387
Reviewed-by: Rob Herring <robh@kernel.org>