Thread (3 messages) 3 messages, 2 authors, 2022-08-12
STALE1413d

[PATCH] wifi: mac80211: clean up a needless assignment in ieee80211_sta_activate_link()

From: Lukas Bulwahn <lukas.bulwahn@gmail.com>
Date: 2022-08-12 09:45:14
Also in: kernel-janitors, lkml
Subsystem: mac80211, the rest · Maintainers: Johannes Berg, Linus Torvalds

Commit 177577dbd223 ("wifi: mac80211: sta_info: fix link_sta insertion")
makes ieee80211_sta_activate_link() return 0 in the 'hash' label case.
Hence, setting ret in the !test_sta_flag(...) branch to zero is not needed
anymore and can be dropped.

Remove a needless assignment.

No functional change. No change in object code.

Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
---
 net/mac80211/sta_info.c | 1 -
 1 file changed, 1 deletion(-)
diff --git a/net/mac80211/sta_info.c b/net/mac80211/sta_info.c
index cb23da9aff1e..492c7a29d797 100644
--- a/net/mac80211/sta_info.c
+++ b/net/mac80211/sta_info.c
@@ -2778,7 +2778,6 @@ int ieee80211_sta_activate_link(struct sta_info *sta, unsigned int link_id)
 	sta->sta.valid_links = new_links;
 
 	if (!test_sta_flag(sta, WLAN_STA_INSERTED)) {
-		ret = 0;
 		goto hash;
 	}
 
-- 
2.17.1
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help