RE: [PATCH v3] rtw88: check for validity before using a pointer
From: Pkshih <pkshih@realtek.com>
Date: 2022-01-21 07:14:59
Also in:
lkml, netdev
-----Original Message----- From: Pkshih <pkshih@realtek.com> Sent: Friday, December 24, 2021 5:01 PM To: Muhammad Usama Anjum <redacted>; Yan-Hsuan Chuang <redacted>; Kalle Valo [off-list ref]; David S. Miller [off-list ref]; Jakub Kicinski [off-list ref]; Bernie Huang [off-list ref]; open list:REALTEK WIRELESS DRIVER (rtw88) [off-list ref]; open list:NETWORKING DRIVERS [off-list ref]; open list [off-list ref] Cc: kernel@collabora.com Subject: RE: [PATCH v3] rtw88: check for validity before using a pointerquoted
-----Original Message----- From: Muhammad Usama Anjum <redacted> Sent: Friday, December 24, 2021 4:55 PM To: Yan-Hsuan Chuang <redacted>; Kalle Valo <kvalo@kernel.org>; David S. Miller [off-list ref]; Jakub Kicinski [off-list ref]; Pkshih [off-list ref]; Bernie Huang [off-list ref]; open list:REALTEK WIRELESS DRIVER (rtw88) [off-list ref]; open list:NETWORKING DRIVERS [off-list ref]; open list [off-list ref] Cc: usama.anjum@collabora.com; kernel@collabora.com Subject: [PATCH v3] rtw88: check for validity before using a pointer ieee80211_probereq_get() can return NULL. Pointer skb should be checked for validty before use. If it is not valid, list of skbs needs to be freed. Fixes: 10d162b2ed39 ("rtw88: 8822c: add ieee80211_ops::hw_scan") Signed-off-by: Muhammad Usama Anjum <redacted>Acked-by: Ping-Ke Shih <pkshih@realtek.com> [...]
I take this patch into my patchset [1], because my new patches are based this patch related to fixes of hw_scan. [1] https://lore.kernel.org/linux-wireless/20220121070813.9656-2-pkshih@realtek.com/T/#u (local) -- Ping-Ke