Thread (55 messages) 55 messages, 3 authors, 2021-12-28
STALE1616d

[PATCH v2 31/50] wilc1000: eliminate another magic constant

From: David Mosberger-Tang <hidden>
Date: 2021-12-23 01:16:57
Also in: lkml, netdev
Subsystem: microchip wilc1000 wifi driver, the rest · Maintainers: Ajay Singh, Claudiu Beznea, Linus Torvalds

Setting bit 1 of the WILC_HOST_VMM_CTL register seems to tell the chip
that the VMM table has been updated and is ready for processing.

Signed-off-by: David Mosberger-Tang <redacted>
---
 drivers/net/wireless/microchip/wilc1000/wlan.c | 3 ++-
 drivers/net/wireless/microchip/wilc1000/wlan.h | 1 +
 2 files changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/net/wireless/microchip/wilc1000/wlan.c b/drivers/net/wireless/microchip/wilc1000/wlan.c
index a4523b0860878..cff70f7d38c89 100644
--- a/drivers/net/wireless/microchip/wilc1000/wlan.c
+++ b/drivers/net/wireless/microchip/wilc1000/wlan.c
@@ -763,7 +763,8 @@ static int send_vmm_table(struct wilc *wilc,
 		if (ret)
 			break;
 
-		ret = func->hif_write_reg(wilc, WILC_HOST_VMM_CTL, 0x2);
+		ret = func->hif_write_reg(wilc, WILC_HOST_VMM_CTL,
+					  WILC_VMM_TABLE_UPDATED);
 		if (ret)
 			break;
 
diff --git a/drivers/net/wireless/microchip/wilc1000/wlan.h b/drivers/net/wireless/microchip/wilc1000/wlan.h
index f5d32ec93fdb9..11a54320ffd05 100644
--- a/drivers/net/wireless/microchip/wilc1000/wlan.h
+++ b/drivers/net/wireless/microchip/wilc1000/wlan.h
@@ -243,6 +243,7 @@
 
 #define WILC_VMM_ENTRY_COUNT		GENMASK(8, 3)
 #define WILC_VMM_ENTRY_AVAILABLE	BIT(2)
+#define WILC_VMM_TABLE_UPDATED		BIT(1)
 /*******************************************/
 /*        E0 and later Interrupt flags.    */
 /*******************************************/
-- 
2.25.1
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help