Re: [PATCH] ath10k: replace strlcpy with strscpy
From: Kalle Valo <kvalo@kernel.org>
Date: 2021-12-22 06:02:22
Also in:
lkml, netdev
From: Kalle Valo <kvalo@kernel.org>
Date: 2021-12-22 06:02:22
Also in:
lkml, netdev
Jason Wang [off-list ref] wrote:
The strlcpy should not be used because it doesn't limit the source length. So that it will lead some potential bugs. But the strscpy doesn't require reading memory from the src string beyond the specified "count" bytes, and since the return value is easier to error-check than strlcpy()'s. In addition, the implementation is robust to the string changing out from underneath it, unlike the current strlcpy() implementation. Thus, replace strlcpy with strscpy. Signed-off-by: Jason Wang <redacted> Signed-off-by: Kalle Valo <redacted>
Patch applied to ath-next branch of ath.git, thanks. 9d364b828ae5 ath10k: replace strlcpy with strscpy -- https://patchwork.kernel.org/project/linux-wireless/patch/20211221070931.725720-1-wangborong@cdjrlc.com/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches