RE: [PATCH] iwlwifi: mei: allow tracing to be disabled
flat view
From: Grumbach, Emmanuel <hidden>
Date: 2021-12-05 18:12:46
Also in:
lkml, netdev
Subject: [PATCH] iwlwifi: mei: allow tracing to be disabled
From: Arnd Bergmann <arnd@arndb.de>
The Makefile conditionally leaves out the trace implementation, but it gets
called unconditionally:
ERROR: modpost: "__SCT__tp_func_iwlmei_me_msg"
[drivers/net/wireless/intel/iwlwifi/mei/iwlmei.ko] undefined!
ERROR: modpost: "__tracepoint_iwlmei_me_msg"
[drivers/net/wireless/intel/iwlwifi/mei/iwlmei.ko] undefined!
ERROR: modpost: "__SCT__tp_func_iwlmei_sap_cmd"
[drivers/net/wireless/intel/iwlwifi/mei/iwlmei.ko] undefined!
ERROR: modpost: "__tracepoint_iwlmei_sap_cmd"
[drivers/net/wireless/intel/iwlwifi/mei/iwlmei.ko] undefined!
ERROR: modpost: "__SCT__tp_func_iwlmei_sap_data"
[drivers/net/wireless/intel/iwlwifi/mei/iwlmei.ko] undefined!
ERROR: modpost: "__tracepoint_iwlmei_sap_data"
[drivers/net/wireless/intel/iwlwifi/mei/iwlmei.ko] undefined!
Use the same macro incantation that is used in the main iwlwifi driver to
leave out the tracing when CONFIG_IWLWIFI_DEVICE_TRACING is disabled.
Fixes: 2da4366f9e2c ("iwlwifi: mei: add the driver to allow cooperation with
CSME")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>Thanks for this, but Kalle just merged a fix I had already sent.