-----Original Message-----
From: Johannes Berg <johannes@sipsolutions.net>
Sent: Monday, December 20, 2021 3:32 PM
To: Rameshkumar Sundaram (QUIC) <redacted>
Cc: linux-wireless@vger.kernel.org; Lavanya Suresh
[off-list ref]
Subject: Re: [PATCH v2] mac80211: disable BSS color collision detection in
case of no free colors

Hi,

quoted

 include/net/cfg80211.h |  28 +++++++------
 net/mac80211/cfg.c     |  16 ++++++--
 net/wireless/nl80211.c | 109
++++++++++++++++++++++++-------------------------
 3 files changed, 82 insertions(+), 71 deletions(-)

This is now a fairly big cfg80211 change, and not much mac80211. Can you
please split it?

But you didn't really address why we need to do this via element change
detection, rather than letting hostapd do this via the
NL80211_ATTR_HE_BSS_COLOR attribute even in change_beacon?

Ah! I totally missed this attribute parsing option and went with ap_params from
last discussion.

Yes, hostapd would send NL80211_ATTR_HE_BSS_COLOR for change_beacon too,
maybe we should relocate cfg80211_he_bss_color to beacon data 
and do nl80211_parse_he_bss_color() in nl80211_parse_beacon() in that case to
have this data for both commands.

johannes