Re: [PATCH 05/10] iwlwifi: mvm: fix 32-bit build in FTM

On Mon, 2021-12-13 at 12:49 +0200, Kalle Valo wrote:

Luca Coelho [off-list ref] writes:

quoted

From: Johannes Berg <redacted>

On a 32-bit build, the division here needs to be done
using do_div(), otherwise the compiler will try to call
a function that doesn't exist, thus failing to build.

Signed-off-by: Johannes Berg <redacted>
Signed-off-by: Luca Coelho <redacted>

Fixes tag? And should this go to wireless-drivers?

I just checked the patch that this claims to fix internally and it's
rather old.  It went into v5.10:

commit b68bd2e3143adbcbc7afd2bc4974c1b988b87211
Author:     Ilan Peer [off-list ref]
AuthorDate: Wed Sep 30 16:31:12 2020 +0300
Commit:     Luca Coelho [off-list ref]
CommitDate: Thu Oct 1 22:00:55 2020 +0300

    iwlwifi: mvm: Add FTM initiator RTT smoothing logic


So, if nobody caught this before, I think neither a Fixes tag nor
taking it to wireless-drivers is necessary.

What do you think?

--
Cheers,
Luca.