Thread (4 messages) 4 messages, 2 authors, 2021-12-08

Re: [PATCH for v5.16] iwlwifi: mvm: don't crash on invalid rate w/o STA

flat view

From: Kalle Valo <kvalo@kernel.org>
Date: 2021-12-03 12:26:28

Luca Coelho [off-list ref] writes:
On Fri, 2021-12-03 at 14:04 +0200, Luca Coelho wrote:
quoted
From: Johannes Berg <redacted>

If we get to the WARN_ONCE(..., "Got a HT rate (...)", ...)
here with a NULL sta, then we crash because mvmsta is bad
and we try to dereference it. Fix that by printing -1 as the
state if no station was given.

Signed-off-by: Johannes Berg <redacted>
Fixes: 6761a718263a ("iwlwifi: mvm: add explicit check for non-data
frames in get Tx rate")
Signed-off-by: Luca Coelho <redacted>
---
Kalle,

Can you take this one directly to wireless-drivers? This fixes a kernel
crash in some situations.
Ok, I took the patch in patchwork.

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help