Re: [PATCH 01/17] bitfield: Add non-constant field_{prep,get}() helpers
From: Jakub Kicinski <kuba@kernel.org>
Date: 2021-11-23 23:49:30
Also in:
alsa-devel, linux-aspeed, linux-clk, linux-gpio, linux-iio, linux-media, linux-mmc, linux-omap, linux-pm, linux-renesas-soc, lkml, netdev
On Tue, 23 Nov 2021 17:24:15 +0100 Johannes Berg wrote:
quoted
(*_replace_bits() seems to be useful, though)Indeed. Also as I said in my other mail, the le32/be32/... variants are tremendously useful, and they fundamentally cannot be expressed with the FIELD_GET() or field_get() macros. IMHO this is a clear advantage to the
Can you elaborate?
typed versions, and if you ask me we should get rid of the FIELD_GETand FIELD_PREP entirely - difficult now, but at least let's not propagate that?
I don't see why.