Re: [PATCH AUTOSEL 4.14 10/39] mwifiex: Run SET_BSS_MODE when changing from P2P to STATION vif-type

On Tue, Nov 09, 2021 at 10:06:19AM -0800, Brian Norris wrote:

On Mon, Nov 8, 2021 at 5:18 PM Sasha Levin [off-list ref] wrote:

quoted

From: Jonas Dreßler <redacted>

[ Upstream commit c2e9666cdffd347460a2b17988db4cfaf2a68fb9 ]

...

quoted

This does not fix any particular bug and just "looked right", so there's
a small chance it might be a regression.

I won't insist on rejecting this one, but especially given this
sentence, this doesn't really pass the smell test for -stable
candidates. It's stuff like this that pushes me a bit toward the camp
of those who despise the ML-based selection methods here, even though
it occasionally (or even often) may produce some good.

I have hundreds of examples of patches that claim they are just an
improvement but fix a serious bug :)

-- 
Thanks,
Sasha