Re: rt2x00 regression
From: Stanislaw Gruszka <stf_xl@wp.pl>
Date: 2021-11-09 12:14:20
Also in:
regressions
Subsystem:
ralink rt2x00 wireless lan driver, the rest · Maintainers:
Stanislaw Gruszka, Linus Torvalds
Possibly related (same subject, not in this thread)
- 2021-11-11 · Re: rt2x00 regression · Exuvo <hidden>
- 2021-11-10 · Re: rt2x00 regression · Stanislaw Gruszka <stf_xl@wp.pl>
- 2021-11-10 · Re: rt2x00 regression · Kalle Valo <hidden>
- 2019-09-27 · Re: rt2x00 regression · Stanislaw Gruszka <hidden>
- 2019-09-26 · rt2x00 regression · Anton Olsson <hidden>
On Tue, Nov 09, 2021 at 08:32:07AM +0100, Stanislaw Gruszka wrote:
On Mon, Nov 08, 2021 at 07:00:20PM +0100, Thorsten Leemhuis wrote:quoted
Sending this again, but this time also to Stanislaw's email address currently found in MAINTAINERS. Stanislaw, can you help with this regression?Yes. I'll check on mail archives what is the status and what can be done.
Ok, so what I can see here https://lore.kernel.org/linux-wireless/20211109073127.GA109212@wp.pl/T/#m6a677995c1afaf6b9b1ff19de9566f304089d3ac (local) is that this problem happen only on firmware load, so I think we can use below patch as fix. Anton, please test it. Thanks Stanislaw
diff --git a/drivers/net/wireless/ralink/rt2x00/rt2x00usb.c b/drivers/net/wireless/ralink/rt2x00/rt2x00usb.c
index e4473a551241..57c947dad036 100644
--- a/drivers/net/wireless/ralink/rt2x00/rt2x00usb.c
+++ b/drivers/net/wireless/ralink/rt2x00/rt2x00usb.c@@ -30,7 +30,8 @@ static bool rt2x00usb_check_usb_error(struct rt2x00_dev *rt2x00dev, int status) else rt2x00dev->num_proto_errs = 0; - if (rt2x00dev->num_proto_errs > 3) + if (rt2x00dev->num_proto_errs > 3 && + !test_bit(DEVICE_STATE_STARTED, &rt2x00dev->flags)) return true; return false;