On 11/3/2021 8:38 AM, Andy Shevchenko wrote:

On Sun, Oct 31, 2021 at 08:56:25PM -0700, Ricardo Martinez wrote:

quoted

From: Haijun Lio <haijun.liu@mediatek.com>

Port-proxy provides a common interface to interact with different types
of ports. Ports export their configuration via `struct t7xx_port` and
operate as defined by `struct port_ops`.

Same here, assuming that the comments from the previous patches are applied
here as well, only unique are given.

Thanks for the feedback.

...

quoted

+	nlh = nlmsg_put(nl_skb, 0, 1, NLMSG_DONE, len, 0);
+	if (!nlh) {
+		dev_err(port->dev, "could not release netlink\n");

I'm wondering why you are not using net_err() / netdev_err() / netif_err()
where it's appropriate.

The original idea was to avoid mixing different types of APIs, but yes, 
it makes sense to use

those APIs where it's appropriate, I'm thinking on using them at 
t7xx_netdev.c where the

required net_device is available.

...

quoted

+		nlmsg_free(nl_skb);
+		return -EFAULT;
+	}

...

+	ccci_h = (struct ccci_header *)skb->data;

Do you need casting?

Yes, skb->data is an unsigned char*

...

...