Re: [regression] mhi: ath11k resume fails on some devices
From: Kalle Valo <hidden>
Date: 2021-10-07 09:48:40
Also in:
ath11k, linux-arm-msm, regressions
(adding the new mhi list, yay) Hi Loic, Loic Poulain [off-list ref] writes:
quoted
Loic Poulain [off-list ref] writes:quoted
On Thu, 16 Sept 2021 at 10:00, Kalle Valo [off-list ref] wrote:quoted
quoted
At the moment I'm running my tests with commit 020d3b26c07a reverted and everything works without problems. Is there a simple way to fix this? Or maybe we should just revert the commit? Commit log and kernel logs from a failing case below.Do you have log of success case?A log from a successful case in the end of email, using v5.15-rc1 plus revert of commit 020d3b26c07abe27.quoted
To me, the device loses power, that is why MHI resuming is failing. Normally the device should be properly recovered/reinitialized. Before that patch the power loss was simply not detected (or handled at higher stack level).Currently in ath11k we always keep the firmware running when in suspend, this is a workaround due to problems between mac80211 and MHI stack. IIRC the problem was something related MHI creating struct device during resume or something like that.Could you give a try with the attached patch? It should solve your issue without breaking modem support.
Sorry for taking so long, but I now tested your patch on top of v5.15-rc3 and, as expected, everything works as before with QCA6390 on NUC x86 testbox. Tested-by: Kalle Valo <redacted> -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches