Re: [PATCH 04/14] firmware_loader: add built-in firmware kconfig entry

On Mon, Oct 11, 2021 at 03:30:24PM -0700, Luis Chamberlain wrote:

On Mon, Oct 11, 2021 at 07:46:04PM +0200, Greg KH wrote:

quoted

quoted

  o By default we now always skip built-in firmware even if a FW_LOADER=y

I do not understand, why would we ever want to skip built-in firmware?

Because it is done this way today only implicitly because
EXTRA_FIRMWARE is empty. Using a kconfig entry makes this
more obvious.

Greg,

The fact that it was not obvious to you we were effectively disabling
the built-in firmware functionality by default using side kconfig
symbols is a good reason to clarify this situation with its own kconfig
symbol.

And consider what I started below as well.

Please let me know why on the other hand we should *not* add this new
kconfig symbol?

quoted

quoted

  o This also lets us make it clear that the EXTRA_FIRMWARE_DIR
    kconfig entry is only used for built-in firmware

How was it ever used for anything else?  :)

Well later this patch set also renames this to something more
sensible, and so that change is clearer through this patch.

quoted

I can not take this as-is, so yes :)

Well please let me know again once you read the above explanations.

I think the new kconfig is very well justified given the above.

  Luis