Thread (2 messages) 2 messages, 2 authors, 2021-10-05

Re: [PATCH v2] rtw88: refine fw_crash debugfs to show non-zero while triggering

From: Kalle Valo <hidden>
Date: 2021-10-05 05:29:14

Ping-Ke Shih [off-list ref] wrote:
From: Zong-Zhe Yang <redacted>

The usage of fw_crash debugfs is to write 1 to it to trigger fw crash
simulation and to read from it to check the state. When zero is read,
it is supposed to mean fw crash/restart process is done. Then, some
test plans can be designed for crash/restart.
e.g.
step 1. trigger fw crash simulation
step 2. poll the state until zero is read
step 3. check connection by ping test

However, in certain connection cases, triggering fw crash simulation
will take a while. If the state is queried too early before restart
begins processing, it may mistakenly think restart process has been
done. If some tests are started at this time, something unexpected
might happen due to the follow-up restart process.

To avoid that, let fw_crash also show non-zero when a simulation
is still triggering.

Signed-off-by: Zong-Zhe Yang <redacted>
Signed-off-by: Ping-Ke Shih <pkshih@realtek.com>
Patch applied to wireless-drivers-next.git, thanks.

6cd4b59ddb1a rtw88: refine fw_crash debugfs to show non-zero while triggering

-- 
https://patchwork.kernel.org/project/linux-wireless/patch/20211001082301.4805-1-pkshih@realtek.com/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help