Re: [RESEND PATCH v2 2/7] nfc: nci: replace GPLv2 boilerplate with SPDX

On Fri, 2021-10-08 at 12:46 +0200, Krzysztof Kozlowski wrote:

On 08/10/2021 12:33, Joe Perches wrote:

quoted

On Thu, 2021-10-07 at 15:30 +0200, Krzysztof Kozlowski wrote:

quoted

Replace standard GPLv2 only license text with SPDX tag.

Nak

This is actually licenced with GPL-2.0-or-later

quoted

diff --git a/net/nfc/nci/uart.c b/net/nfc/nci/uart.c

[]

quoted

@@ -1,20 +1,8 @@
+// SPDX-License-Identifier: GPL-2.0

[]
You may use, redistribute and/or modify this File in

quoted

- * accordance with the terms and conditions of the License, a copy of which
- * is available on the worldwide web at
- * http://www.gnu.org/licenses/old-licenses/gpl-2.0.txt.

See the actual text at the old link which includes:

    This program is free software; you can redistribute it and/or modify
    it under the terms of the GNU General Public License as published by
    the Free Software Foundation; either version 2 of the License, or
    (at your option) any later version.

Thanks Joe for checking this. Isn't this conflicting with first
paragraph in the source file:

  This software file (the "File") is distributed by Marvell
InternationalLtd. under the terms of the GNU General Public License
Version 2, June 1991(the "License").

This part does not specify "or later".

It doesn't need to as it calls out the exact license which by
specific reference includes the "or later".

And this is a nominal 'weakness' in the spdx license referencing
system which relies on contents of files in the LICENSE directory.