Re: [PATCH v3] ath10k: Don't always treat modem stop events as crashes
From: Kalle Valo <hidden>
Date: 2021-10-05 14:27:10
Also in:
linux-arm-msm, lkml, netdev
From: Kalle Valo <hidden>
Date: 2021-10-05 14:27:10
Also in:
linux-arm-msm, lkml, netdev
Stephen Boyd [off-list ref] wrote:
When rebooting on sc7180 Trogdor devices I see the following crash from
the wifi driver.
ath10k_snoc 18800000.wifi: firmware crashed! (guid 83493570-29a2-4e98-a83e-70048c47669c)
This is because a modem stop event looks just like a firmware crash to
the driver, the qmi connection is closed in both cases. Use the qcom ssr
notifier block to stop treating the qmi connection close event as a
firmware crash signal when the modem hasn't actually crashed. See
ath10k_qmi_event_server_exit() for more details.
This silences the crash message seen during every reboot.
Fixes: 3f14b73c3843 ("ath10k: Enable MSA region dump support for WCN3990")
Cc: Youghandhar Chintala <redacted>
Cc: Abhishek Kumar <redacted>
Cc: Steev Klimaszewski <redacted>
Cc: Matthias Kaehlcke <mka@chromium.org>
Cc: Rakesh Pillai <redacted>
Signed-off-by: Stephen Boyd <redacted>
Reviewed-by: Rakesh Pillai <redacted>
Tested-By: Youghandhar Chintala <redacted>
Signed-off-by: Kalle Valo <redacted>Patch applied to ath-next branch of ath.git, thanks. 747ff7d3d742 ath10k: Don't always treat modem stop events as crashes -- https://patchwork.kernel.org/project/linux-wireless/patch/20210922233341.182624-1-swboyd@chromium.org/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches