Re: [PATCH v7 12/24] wfx: add hif_api_*.h
From: Kalle Valo <hidden>
Date: 2021-10-01 11:49:15
Also in:
linux-devicetree, linux-mmc, lkml, netdev
Possibly related (same subject, not in this thread)
- 2021-10-01 · Re: [PATCH v7 12/24] wfx: add hif_api_*.h · Kalle Valo <hidden>
- 2021-10-01 · Re: [PATCH v7 12/24] wfx: add hif_api_*.h · Jérôme Pouiller <jerome.pouiller@silabs.com>
- 2021-10-01 · Re: [PATCH v7 12/24] wfx: add hif_api_*.h · Kalle Valo <hidden>
- 2021-10-01 · Re: [PATCH v7 12/24] wfx: add hif_api_*.h · Kalle Valo <hidden>
- 2021-09-20 · [PATCH v7 12/24] wfx: add hif_api_*.h · Jerome Pouiller <Jerome.Pouiller@silabs.com>
Jerome Pouiller [off-list ref] writes:
From: Jérôme Pouiller <jerome.pouiller@silabs.com> Signed-off-by: Jérôme Pouiller <jerome.pouiller@silabs.com>
[...]
quoted hunk
--- /dev/null +++ b/drivers/net/wireless/silabs/wfx/hif_api_general.h@@ -0,0 +1,256 @@ +/* SPDX-License-Identifier: Apache-2.0 */ +/* + * WF200 hardware interface definitions + * + * Copyright (c) 2018-2020, Silicon Laboratories Inc. + */ + +#ifndef WFX_HIF_API_GENERAL_H +#define WFX_HIF_API_GENERAL_H + +#include <linux/types.h> +#include <linux/if_ether.h>
I'm looking at staging-next (commit 42ce32b1ae54) while reviewing the driver and there I see: #ifndef WFX_HIF_API_GENERAL_H #define WFX_HIF_API_GENERAL_H #ifdef __KERNEL__ #include <linux/types.h> #include <linux/if_ether.h> #else #include <net/ethernet.h> #include <stdint.h> #define __packed __attribute__((__packed__)) #endif I don't know what's causing the difference, but that ifdef __KERNEL__ looks useless. -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches