[PATCH] net: wlcore: spi: Use dev_err_probe()

Subsystems: the rest, ti wilink wireless drivers

STALE1777d LANDED

Landed in mainline as 1aa3367ca78c on 2021-10-27.

2 messages, 2 authors, 2021-10-27 · open the first message on its own page

[PATCH] net: wlcore: spi: Use dev_err_probe()

From: Geert Uytterhoeven <geert+renesas@glider.be>
Date: 2021-10-19 12:48:47

Use the existing dev_err_probe() helper instead of open-coding the same
operation.

Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
Compile-tested only.
---
 drivers/net/wireless/ti/wlcore/spi.c | 9 +++------
 1 file changed, 3 insertions(+), 6 deletions(-)
diff --git a/drivers/net/wireless/ti/wlcore/spi.c b/drivers/net/wireless/ti/wlcore/spi.c
index f26fc150ecd01460..354a7e1c3315c6e2 100644
--- a/drivers/net/wireless/ti/wlcore/spi.c
+++ b/drivers/net/wireless/ti/wlcore/spi.c
@@ -488,12 +488,9 @@ static int wl1271_probe(struct spi_device *spi)
 	spi->bits_per_word = 32;
 
 	glue->reg = devm_regulator_get(&spi->dev, "vwlan");
-	if (PTR_ERR(glue->reg) == -EPROBE_DEFER)
-		return -EPROBE_DEFER;
-	if (IS_ERR(glue->reg)) {
-		dev_err(glue->dev, "can't get regulator\n");
-		return PTR_ERR(glue->reg);
-	}
+	if (IS_ERR(glue->reg))
+		return dev_err_probe(glue->dev, PTR_ERR(glue->reg),
+				     "can't get regulator\n");
 
 	ret = wlcore_probe_of(spi, glue, pdev_data);
 	if (ret) {
-- 
2.25.1

Re: wlcore: spi: Use dev_err_probe()

From: Kalle Valo <hidden>
Date: 2021-10-27 07:32:10

Geert Uytterhoeven [off-list ref] wrote:
Use the existing dev_err_probe() helper instead of open-coding the same
operation.

Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Patch applied to wireless-drivers-next.git, thanks.

1aa3367ca78c wlcore: spi: Use dev_err_probe()

-- 
https://patchwork.kernel.org/project/linux-wireless/patch/465e76901b801ac0755088998249928fd546c08a.1634647460.git.geert+renesas@glider.be/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help