Re: [PATCH v12 4/4] mac80211: MBSSID channel switch
From: Johannes Berg <johannes@sipsolutions.net>
Date: 2021-09-28 09:49:14
On Wed, 2021-09-15 at 19:54 -0700, Aloka Dixit wrote:
quoted hunk ↗ jump to hunk
diff --git a/net/mac80211/cfg.c b/net/mac80211/cfg.c index 23fa0bb49be2..88fbed46e1bc 100644 --- a/net/mac80211/cfg.c +++ b/net/mac80211/cfg.c@@ -3271,8 +3271,19 @@ void ieee80211_csa_finish(struct ieee80211_vif *vif){ struct ieee80211_sub_if_data *sdata = vif_to_sdata(vif); - ieee80211_queue_work(&sdata->local->hw, - &sdata->csa_finalize_work); + if (vif->mbssid_tx_vif == vif) { + struct ieee80211_sub_if_data *child, *tmp; + + list_for_each_entry_safe(child, tmp, + &sdata->local->interfaces, list)
I don't see any reason to believe that this list iteration should be safe? johannes