Re: [PATCH] [v15] wireless: Initial driver submission for pureLiFi STA devices
From: Kalle Valo <hidden>
Date: 2021-09-20 13:05:25
Also in:
lkml, netdev
Possibly related (same subject, not in this thread)
- 2021-09-24 · Re: [PATCH] [v15] wireless: Initial driver submission for pureLiFi STA devices · Kalle Valo <hidden>
- 2021-09-20 · Re: [PATCH] [v15] wireless: Initial driver submission for pureLiFi STA devices · Kalle Valo <hidden>
- 2021-08-18 · [PATCH] [v15] wireless: Initial driver submission for pureLiFi STA devices · Srinivasan Raju <srini.raju@purelifi.com>
(big picture comments first) Srinivasan Raju [off-list ref] writes:
This introduces the pureLiFi LiFi driver for LiFi-X, LiFi-XC and LiFi-XL USB devices. This driver implementation has been based on the zd1211rw driver. Driver is based on 802.11 softMAC Architecture and uses native 802.11 for configuration and management. The driver is compiled and tested in ARM, x86 architectures and compiled in powerpc architecture.
You should describe in the commit log what LiFi means, not everyone know the term and might mistake this as a regular Wi-Fi device (which it's not).
+ hw->wiphy->bands[NL80211_BAND_2GHZ] = &mac->band;
Johannes comment about piggy-backing NL80211_BAND_2GHZ is not yet addressed: https://patchwork.kernel.org/project/linux-wireless/patch/20210212115030.124490-1-srini.raju@purelifi.com/ I agree with Johannes, a Li-Fi driver should not claim to be a regular 2.4 GHz Wi-Fi device. -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches