Re: [PATCH] kconfig: forbid symbols that end with '_MODULE'

On 26/08/2021 05:28, Masahiro Yamada wrote:

On Wed, Aug 25, 2021 at 8:59 PM Péter Ujfalusi [off-list ref] wrote:

...

quoted

quoted

diff --git a/sound/soc/ti/Kconfig b/sound/soc/ti/Kconfig
index 698d7bc84dcf..c56a5789056f 100644
--- a/sound/soc/ti/Kconfig
+++ b/sound/soc/ti/Kconfig

@@ -211,7 +211,7 @@ config SND_SOC_DM365_VOICE_CODEC
        Say Y if you want to add support for SoC On-chip voice codec
 endchoice

-config SND_SOC_DM365_VOICE_CODEC_MODULE
+config SND_SOC_DM365_VOICE_CODEC_MODULAR

This Kconfig option is only used to select the codecs needed for the
voice mode, I think it would be better to use something like

SND_SOC_DM365_SELECT_VOICE_CODECS ?

I do not have a strong opinion.
I am fine with any name unless it ends with _MODULE.


The sound subsystem maintainers and Arnd,
author of 147162f575152db800 are CC'ed.

If they suggest a better name, I'd be happy to adopt it.

Can you resend (a separate patch would be even better) with
SND_SOC_DM365_SELECT_VOICE_CODECS

for sound/soc/ti/Kconfig ?

Thank you,
Péter