Re: [PATCH v2 55/63] HID: roccat: Use struct_group() to zero kone_mouse_event
From: Kees Cook <hidden>
Date: 2021-08-20 15:57:32
Also in:
dri-devel, linux-block, linux-hardening, linux-input, linux-kbuild, linux-staging, lkml, netdev
Possibly related (same subject, not in this thread)
- 2021-08-20 · Re: [PATCH v2 55/63] HID: roccat: Use struct_group() to zero kone_mouse_event · Jiri Kosina <jikos@kernel.org>
- 2021-08-18 · [PATCH v2 55/63] HID: roccat: Use struct_group() to zero kone_mouse_event · Kees Cook <hidden>
On Fri, Aug 20, 2021 at 05:27:35PM +0200, Jiri Kosina wrote:
On Fri, 20 Aug 2021, Kees Cook wrote:quoted
quoted
quoted
In preparation for FORTIFY_SOURCE performing compile-time and run-time field bounds checking for memset(), avoid intentionally writing across neighboring fields. Add struct_group() to mark region of struct kone_mouse_event that should be initialized to zero. Cc: Stefan Achatz <erazor_de@users.sourceforge.net> Cc: Jiri Kosina <jikos@kernel.org> Cc: Benjamin Tissoires <redacted> Cc: linux-input@vger.kernel.org Signed-off-by: Kees Cook <redacted>Applied, thank you Kees.Eek! No, this will break the build: struct_group() is not yet in the tree. I can carry this with an Ack, etc.I was pretty sure I saw struct_group() already in linux-next, but that was apparently a vacation-induced brainfart, sorry. Dropping.
Oh, for these two patches, can I add your Acked-by while I carry them? Thanks! -- Kees Cook