Re: [PATCH RFC v1 3/7] rtw88: Use rtw_iterate_stas where the iterator reads... | linux-wireless

[PATCH RFC v1 0/7] rtw88: prepare locking for SDIO support · Martin Blumenstingl <martin.blumenstingl@googlemail.com> · 2021-07-17
[PATCH RFC v1 1/7] mac80211: Add stations iterator where the iterator function may sleep · Martin Blumenstingl <martin.blumenstingl@googlemail.com> · 2021-07-17
RE: [PATCH RFC v1 1/7] mac80211: Add stations iterator where the iterator function may sleep · Pkshih <pkshih@realtek.com> · 2021-07-19
Re: [PATCH RFC v1 1/7] mac80211: Add stations iterator where the iterator function may sleep · Johannes Berg <johannes@sipsolutions.net> · 2021-07-19
[PATCH RFC v1 2/7] rtw88: Use rtw_iterate_vifs where the iterator reads or writes registers · Martin Blumenstingl <martin.blumenstingl@googlemail.com> · 2021-07-17
RE: [PATCH RFC v1 2/7] rtw88: Use rtw_iterate_vifs where the iterator reads or writes registers · Pkshih <pkshih@realtek.com> · 2021-07-19
Re: [PATCH RFC v1 2/7] rtw88: Use rtw_iterate_vifs where the iterator reads or writes registers · Martin Blumenstingl <martin.blumenstingl@googlemail.com> · 2021-07-25
RE: [PATCH RFC v1 2/7] rtw88: Use rtw_iterate_vifs where the iterator reads or writes registers · Pkshih <pkshih@realtek.com> · 2021-07-26
[PATCH RFC v1 3/7] rtw88: Use rtw_iterate_stas where the iterator reads or writes registers · Martin Blumenstingl <martin.blumenstingl@googlemail.com> · 2021-07-17
Re: [PATCH RFC v1 3/7] rtw88: Use rtw_iterate_stas where the iterator reads or writes registers · Johannes Berg <johannes@sipsolutions.net> · 2021-07-19
Re: [PATCH RFC v1 3/7] rtw88: Use rtw_iterate_stas where the iterator reads or writes registers · Martin Blumenstingl <martin.blumenstingl@googlemail.com> · 2021-07-25
RE: [PATCH RFC v1 3/7] rtw88: Use rtw_iterate_stas where the iterator reads or writes registers · Pkshih <pkshih@realtek.com> · 2021-07-26
Re: [PATCH RFC v1 3/7] rtw88: Use rtw_iterate_stas where the iterator reads or writes registers · Johannes Berg <johannes@sipsolutions.net> · 2021-08-09
[PATCH RFC v1 4/7] rtw88: Replace usage of rtw_iterate_keys_rcu() with rtw_iterate_keys() · Martin Blumenstingl <martin.blumenstingl@googlemail.com> · 2021-07-17
[PATCH RFC v1 7/7] rtw88: fw: Convert h2c.lock from a spinlock to a mutex · Martin Blumenstingl <martin.blumenstingl@googlemail.com> · 2021-07-17
[PATCH RFC v1 5/7] rtw88: Configure the registers from rtw_bf_assoc() outside the RCU lock · Martin Blumenstingl <martin.blumenstingl@googlemail.com> · 2021-07-17
RE: [PATCH RFC v1 5/7] rtw88: Configure the registers from rtw_bf_assoc() outside the RCU lock · Pkshih <pkshih@realtek.com> · 2021-07-19
Re: [PATCH RFC v1 5/7] rtw88: Configure the registers from rtw_bf_assoc() outside the RCU lock · Martin Blumenstingl <martin.blumenstingl@googlemail.com> · 2021-07-25
RE: [PATCH RFC v1 5/7] rtw88: Configure the registers from rtw_bf_assoc() outside the RCU lock · Pkshih <pkshih@realtek.com> · 2021-07-26
[PATCH RFC v1 6/7] rtw88: hci: Convert rf_lock from a spinlock to a mutex · Martin Blumenstingl <martin.blumenstingl@googlemail.com> · 2021-07-17
RE: [PATCH RFC v1 0/7] rtw88: prepare locking for SDIO support · Pkshih <pkshih@realtek.com> · 2021-07-19

Re: [PATCH RFC v1 3/7] rtw88: Use rtw_iterate_stas where the iterator reads or writes registers

From: Johannes Berg <johannes@sipsolutions.net>
Date: 2021-08-09 20:00:52
Also in: lkml, netdev

I am thinking rtw88 needs to maintain sta and vif lists itself,

I would tend to prefer drivers do not maintain separate lists - that's
just duplicated book-keeping and prone to state mismatch errors?

But OTOH the locking does make things complex.

johannes

`h`	back out one level
`j`	next message in thread
`k`	previous message in thread
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help