Re: [PATCH] ath5k: fix building with LEDS=m

(oddly linux-wireless was dropped, adding it back in hopes that
patchwork sees this)

Arnd Bergmann [off-list ref] writes:

On Fri, Jul 23, 2021 at 10:41 AM kernel test robot [off-list ref] wrote:

quoted

All errors (new ones prefixed by >>):

   mips-linux-ld: drivers/net/wireless/ath/ath5k/led.o: in function
`ath5k_register_led.constprop.0':

quoted

quoted

led.c:(.text+0x58): undefined reference to `led_classdev_register_ext'

   mips-linux-ld: drivers/net/wireless/ath/ath5k/led.o: in function
`ath5k_unregister_leds':

quoted

quoted

led.c:(.text+0x1d8): undefined reference to `led_classdev_unregister'
mips-linux-ld: led.c:(.text+0x208): undefined reference to
`led_classdev_unregister'

Ok, nevermind then, please ignore my patch. I don't see this
particular build failure on
my randconfig test box, which probably means I have some other patch
applied that
avoids this. I may get back to this in the future but can't figure it
out at the moment.

My feeling now is that the 'select' should just be removed entirely, and then
we can have an 'if (!IS_ENABLED(CONFIG_MAC80211_LEDS)) return 0;'
in ath5k_register_led().

       Arnd

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches