Thread (9 messages) 9 messages, 2 authors, 2021-08-18

Re: [PATCH net-next 2/4] ethtool: extend coalesce setting uAPI with CQE mode

From: moyufeng <hidden>
Date: 2021-08-18 01:57:48
Also in: netdev


On 2021/8/17 21:39, Jakub Kicinski wrote:
On Tue, 17 Aug 2021 10:36:05 +0800 Yufeng Mo wrote:
quoted
In order to support more coalesce parameters through netlink,
add an new structure kernel_ethtool_coalesce, and keep
struct ethtool_coalesce as the base(legacy) part, then the
new parameter can be added into struct kernel_ethtool_coalesce.

Also add new extack parameter for .set_coalesce and .get_coalesce
then some extra info can return to user with the netlink API.

Signed-off-by: Yufeng Mo <redacted>
Signed-off-by: Huazhong Tan <redacted>
This and the following patches don't build, please make sure
allmodconfig builds correctly. Here's an example failure, but
IDK if there isn't more:

drivers/net/ethernet/ti/davinci_emac.c: In function ‘emac_dev_open’:
drivers/net/ethernet/ti/davinci_emac.c:1469:3: error: too few arguments to function ‘emac_set_coalesce’
 1469 |   emac_set_coalesce(ndev, &coal);
      |   ^~~~~~~~~~~~~~~~~
.
Sorry, I'll check allmodconfig again and make sure all builds correctly.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help