Re: [PATCH v2 1/4] iwlwifi: mei: add the driver to allow cooperation with CSME

Emmanuel Grumbach [off-list ref] writes:

On Tue, Jun 22, 2021 at 4:32 PM Kalle Valo [off-list ref] wrote:

quoted

Emmanuel Grumbach [off-list ref] writes:

quoted

iwlmei is a driver that handles the communication with the
Wireless driver of the CSME firmware.
More details in the documentation included in this patch.

A complicated new feature and just two sentences in the commit log? The
commit log should give a proper overview what the patch does and why.
This commit log really says to the reader "I don't care, find out
yourself".

And being nice I did try to read few paragraphs from the patch but as I
didn't even see any explanation for CSME or SAP I gave up.

CSME stands for converged security and management engine.
It is well known and has a driver in the kernel under drivers/misc/mei

It maybe well known to you but it's not for me, and I'm pretty sure I'm
not the only one. Remember that not everyone work for Intel and this is
a community project, so please write commit logs accordingly.

But I see that you submitted v3, good. I'm reading that right now.

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches