Thread (24 messages) 24 messages, 2 authors, 2021-06-24

Re: [PATCH 09/12] wilc1000: avoid 'isinit' static by moving inside priv data

From: Kalle Valo <hidden>
Date: 2021-06-24 09:41:30

[off-list ref] writes:
From: Ajay Singh <ajay.kathat@microchip.com>

Instead of using static variable(isinit) move to priv struct.
Added hif_is_init function to set is_init variable.
This is a good patch. But I also see one more static non-const variable:

wlan.c:       static u32 chipid;

Upstream drivers should not use static variables, unless they are const.
Please fix that also, but in a separate patch of course.

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help