Re: Memory leak in rtw88-pci
From: Larry Finger <hidden>
Date: 2021-06-20 19:33:30
On 6/17/21 5:54 PM, Brian Norris wrote:
On Sun, Apr 11, 2021 at 12:35 PM Larry Finger [off-list ref] wrote:quoted
On 4/8/21 11:12 PM, Klaus Müller wrote:quoted
May I kindly bring up this reported problem again? Is there anybody working on this problem? Or did I miss the already existing fix?A fix has been found. The patched code is available at https://GitHub.com/lwfinger/rtw88.git. Patches are being prepared for wireless-next. From there, they will propagate into the Linux distributions.Did you ever submit the second half of that patch? https://github.com/lwfinger/rtw88/commit/0eed97166d54cf6fa03e20735b9c208375b8c949 (modifications to rtw_fw_c2h_cmd_rx_irqsafe()) We're still seeing leaks here with kmemleak, although I'm using a 5.4.y kernel, so maybe don't have all the latest fixes yet. NB: I *do* have this: https://git.kernel.org/linus/191f6b08bfef as it made it to 5.4.y.
Brian, I fixed the leaks, but forgot to submit the patch. My repo at https://github.com/lafingerrtw88.git has the fixes, and does have any leaks on my system. The patch just pushed has the same fixes. Larry