Re: [PATCH] wcn36xx: Move hal_buf allocation to devm_kmalloc in probe
From: Kalle Valo <hidden>
Date: 2021-06-12 11:05:07
From: Kalle Valo <hidden>
Date: 2021-06-12 11:05:07
Bryan O'Donoghue [off-list ref] writes:
Right now wcn->hal_buf is allocated in wcn36xx_start(). This is a problem
since we should have setup all of the buffers we required by the time
ieee80211_register_hw() is called.
struct ieee80211_ops callbacks may run prior to mac_start() and therefore
wcn->hal_buf must be initialized.
This is easily remediated by moving the allocation to probe() taking the
opportunity to tidy up freeing memory by using devm_kmalloc().
Fixes: 8e84c2582169 ('wcn36xx: mac80211 driver for Qualcomm WCN3660/WCN3680
hardware')
Fixes tag is wrong, it should be like this and all in one line:
Fixes: 8e84c2582169 ("wcn36xx: mac80211 driver for Qualcomm WCN3660/WCN3680 hardware")
I fixed it in the pending branch, no need to resend.
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches