Re: [PATCH] brcmfmac: fix a loop exit condition
From: Kalle Valo <hidden>
Date: 2021-06-15 10:27:27
Also in:
kernel-janitors
Dan Carpenter [off-list ref] wrote:
This code is supposed to loop over the whole board_type[] string. The
current code kind of works just because ascii values start 97 and the
string is likely shorter than that so it will break when we hit the NUL
terminator. But really the condition should be "i < len" instead of
"i < board_type[i]".
Fixes: 29e354ebeeec ("brcmfmac: Transform compatible string for FW loading")
Signed-off-by: Dan Carpenter <redacted>
Reviewed-by: Matthias Brugger <mbrugger@suse.com>There was talk about v2, but I don't see it in the patchwork. Patch set to Changes Requested. -- https://patchwork.kernel.org/project/linux-wireless/patch/YIKzmoMiTdToaIyP@mwanda/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches