Thread (21 messages) 21 messages, 4 authors, 2021-06-12

Re: [PATCH V4 06/16] net: iosm: channel configuration

From: Sergey Ryazanov <ryazanov.s.a@gmail.com>
Date: 2021-06-12 01:11:06
Also in: netdev

Hello Chetan,

On Tue, Jun 8, 2021 at 8:07 PM M Chetan Kumar [off-list ref] wrote:

[skipped]
+/* Modem channel configuration table
+ * Always reserve element zero for flash channel.
+ */
+static struct ipc_chnl_cfg modem_cfg[] = {
+       /* IP Mux */
+       { IPC_MEM_IP_CHL_ID_0, IPC_MEM_PIPE_0, IPC_MEM_PIPE_1,
+         IPC_MEM_MAX_TDS_MUX_LITE_UL, IPC_MEM_MAX_TDS_MUX_LITE_DL,
+         IPC_MEM_MAX_DL_MUX_LITE_BUF_SIZE, WWAN_PORT_MAX },
Since commit b64d76b78226 ("net: wwan: make WWAN_PORT_MAX meaning less
surprised") WWAN_PORT_MAX really means a maximum valid port type id.
At the moment the max value is WWAN_PORT_FIREHOSE. If I understand the
driver code correctly, you ignore WWAN_PORT_MAX ports in the
ipc_imem_run_state_worker() function. So using WWAN_PORT_MAX in this
way should not actually break anything.

Just as a FYI, Loic introduced a special value WWAN_PORT_UNKNOWN that
could be used to indicate a port that should not be registered with
the WWAN core. Looks like WWAN_PORT_UNKNOWN would be a safer
alternative here.

-- 
Sergey
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help