Thread (3 messages) 3 messages, 3 authors, 2021-06-15

Re: [PATCH 1/1] ssb: Fix error return code in ssb_bus_scan()

From: Michael Büsch <m@bues.ch>
Date: 2021-05-15 14:55:10

On Sat, 15 May 2021 15:29:49 +0800
Zhen Lei [off-list ref] wrote:
Fix to return -EINVAL from the error handling case instead of 0, as done
elsewhere in this function.
quoted hunk ↗ jump to hunk
@@ -325,6 +325,7 @@ int ssb_bus_scan(struct ssb_bus *bus,
 	if (bus->nr_devices > ARRAY_SIZE(bus->devices)) {
 		pr_err("More than %d ssb cores found (%d)\n",
 		       SSB_MAX_NR_CORES, bus->nr_devices);
+		err = -EINVAL;
 		goto err_unmap;
 	}
 	if (bus->bustype == SSB_BUSTYPE_SSB) {

Acked-by: Michael Büsch <m@bues.ch>

-- 
Michael

Attachments

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help