Re: [PATCH] rtw88: Fix an error code in rtw_debugfs_set_rsvd_page()

On Mon, Mar 15, 2021 at 08:08:17AM +0000, Kalle Valo wrote:

Dan Carpenter [off-list ref] wrote:

quoted

The sscanf() function returns either 0 or 1 here.  It doesn't return
error codes.  We should return -EINVAL if the string is invalid.

Fixes: c376c1fc87b7 ("rtw88: add h2c command in debugfs")
Signed-off-by: Dan Carpenter <redacted>

Why do you remove the num variable? I think the code is more readable with it.

The way I wrote it is slightly more normal (457 vs 333) and we don't use
"num" except for the one if statement.  But I can write the other way.
I'll resend.

regards,
dan carpenter