Thread (6 messages) 6 messages, 2 authors, 2021-03-18

Re: [PATCH v7 1/3] ath11k: switch to using ieee80211_tx_status_ext()

From: Pradeep Kumar Chitrapu <hidden>
Date: 2021-03-18 20:25:15
Also in: ath11k

quoted
+	spin_lock_bh(&ab->base_lock);
+	peer = ath11k_peer_find_by_id(ab, ts->peer_id);
+	if (peer) {
+		arsta = (struct ath11k_sta *)peer->sta->drv_priv;
+		status.sta = peer->sta;
+		status.skb = msdu;
+		status.info = info;
+		status.rate = &arsta->last_txrate;
+	}
+	rcu_read_unlock();
+	if (peer)
+		ieee80211_tx_status_ext(ar->hw, &status);
+	else
+		dev_kfree_skb_any(msdu);
+	spin_unlock_bh(&ab->base_lock);
Why ieee80211_tx_status_ext() kept under spin_lock?

Thanks,
Karthikeyan P
Thanks Karthikeyan for the review..Yes, spin lock could be avoided for
ieee80211_tx_status_ext(). I will address this in next revision.

Thanks
pradeep
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help