Re: [PATCH 2/2] mt76: mt7921: remove incorrect error handling
From: Kalle Valo <hidden>
Date: 2021-02-26 09:25:29
Also in:
lkml, netdev
From: Kalle Valo <hidden>
Date: 2021-02-26 09:25:29
Also in:
lkml, netdev
Arnd Bergmann [off-list ref] wrote:
From: Arnd Bergmann <arnd@arndb.de>
Clang points out a mistake in the error handling in
mt7921_mcu_tx_rate_report(), which tries to dereference a pointer that
cannot be initialized because of the error that is being handled:
drivers/net/wireless/mediatek/mt76/mt7921/mcu.c:409:3: warning: variable 'stats' is uninitialized when used here [-Wuninitialized]
stats->tx_rate = rate;
^~~~~
drivers/net/wireless/mediatek/mt76/mt7921/mcu.c:401:32: note: initialize the variable 'stats' to silence this warning
struct mt7921_sta_stats *stats;
^
Just remove the obviously incorrect line.
Fixes: 1c099ab44727 ("mt76: mt7921: add MCU support")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Reviewed-by: Nick Desaulniers <redacted>Patch applied to wireless-drivers.git, thanks. fb5fabb192b2 mt76: mt7921: remove incorrect error handling -- https://patchwork.kernel.org/project/linux-wireless/patch/20210225145953.404859-2-arnd@kernel.org/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches