Thread (2 messages) 2 messages, 2 authors, 2021-02-11

Re: [PATCH v2] wilc1000: Fix use of void pointer as a wrong struct type

flat view

From: Kalle Valo <hidden>
Date: 2021-02-11 06:47:27

Vsevolod Kozlov [off-list ref] wrote:
ac_classify() expects a struct sk_buff* as its second argument, which is
a member of struct tx_complete_data. priv happens to be a pointer to
struct tx_complete_data, so passing it directly to ac_classify() leads
to wrong behaviour and occasional panics.

Since there is only one caller of wilc_wlan_txq_add_net_pkt and it
already knows the type behind this pointer, and the structure is already
in the header file, change the function signature to use the real type
instead of void* in order to prevent confusion.

Signed-off-by: Vsevolod Kozlov <redacted>
Patch applied to wireless-drivers-next.git, thanks.

6fe91b69cece wilc1000: Fix use of void pointer as a wrong struct type

-- 
https://patchwork.kernel.org/project/linux-wireless/patch/YCQomJ1mO5BLxYOT@Vsevolods-Mini.lan/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help