Thread (2 messages) 2 messages, 2 authors, 2021-01-25

Re: [PATCH] iwl4965: do not process non-QOS frames on txq->sched_retry path

From: Kalle Valo <hidden>
Date: 2021-01-25 14:47:39

stf_xl@wp.pl wrote:
From: Stanislaw Gruszka <stf_xl@wp.pl>

We have already WARN_ON(!qc) for non-QOS frame on txq->sched_retry path,
but we continue to process, what makes no sense since tid is not
initialized. Non QOS frame should never happen when aggregation
is enabled on queue, so do not process that.

Patch should fix smatch warning:
drivers/net/wireless/intel/iwlegacy/4965-mac.c:2822 il4965_hdl_tx() error: uninitialized symbol 'tid'.

Reported-by: kernel test robot <redacted>
Reported-by: Dan Carpenter <redacted>
Signed-off-by: Stanislaw Gruszka <stf_xl@wp.pl>
Patch applied to wireless-drivers-next.git, thanks.

4832bb371c41 iwl4965: do not process non-QOS frames on txq->sched_retry path

-- 
https://patchwork.kernel.org/project/linux-wireless/patch/20210119100621.439134-1-stf_xl@wp.pl/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help